tobias/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-11-10 01:33:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

ci/github-script/reviewers: add TODO about future optimization

Browse source 
We still use a few too many API requests by checking team members for
collaborator status - we can improve on that in the future.
This commit is contained in:
Wolfgang Walther 2025-11-06 16:11:36 +01:00
parent 9efe926863
commit 17199e5ff6
No known key found for this signature in database
GPG key ID: B39893FA5F65CAE1
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ci/github-script/reviewers.js
View file

@ -75,6 +75,9 @@ async function handleReviewers({
const reviewers = ( const reviewers = (
await Promise.all( await Promise.all(
Array.from(new_reviewers, async (username) => { Array.from(new_reviewers, async (username) => {
// TODO: Restructure this file to only do the collaborator check for those users
// who were not already part of a team. Being a member of a team makes them
// collaborators by definition.
try { try {
await github.rest.repos.checkCollaborator({ await github.rest.repos.checkCollaborator({
...context.repo, ...context.repo,