tobias/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-11-09 16:18:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

ci/github-script/merge: improve caching of team members

Browse source 
This removes the need to `await` committers further down in the function
and allows re-using the cache for other teams later.
This commit is contained in:
Wolfgang Walther 2025-11-02 10:11:42 +01:00
parent 7c9035e29d
commit c7766c637f
No known key found for this signature in database
GPG key ID: B39893FA5F65CAE1
1 changed files with 14 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
ci/github-script/merge.js
View file

@ -1,27 +1,32 @@
// Caching the list of committers saves API requests when running the bot on the schedule and
// Caching the list of team members saves API requests when running the bot on the schedule and
// processing many PRs at once.
let committers
const members = {}
async function runChecklist({ github, context, pull_request, maintainers }) {
const pull_number = pull_request.number
if (!committers) {
function getTeamMembers(team_slug) {
if (context.eventName === 'pull_request') {
// We have no chance of getting a token in the pull_request context with the right
// permissions to access the members endpoint below. Thus, we're pretending to have
// no committers. This is OK; because this is only for the Test workflow, not for
// no members. This is OK; because this is only for the Test workflow, not for
// real use.
committers = new Set()
} else {
committers = github
return new Set()
}
if (!members[team_slug]) {
members[team_slug] = github
.paginate(github.rest.teams.listMembersInOrg, {
org: context.repo.owner,
team_slug: 'nixpkgs-committers',
team_slug,
per_page: 100,
})
.then((members) => new Set(members.map(({ id }) => id)))
}
return members[team_slug]
}
committers = await getTeamMembers('nixpkgs-committers')
const files = await github.paginate(github.rest.pulls.listFiles, {
...context.repo,
@ -50,7 +55,7 @@ async function runChecklist({ github, context, pull_request, maintainers }) {
),
'PR authored by r-ryantm or committer.':
pull_request.user.login === 'r-ryantm' ||
(await committers).has(pull_request.user.id),
committers.has(pull_request.user.id),
'PR has maintainers eligible for merge.': eligible.size > 0,
}