nixpkgs/nixos/modules
Robert Obryk ff204ca32b nixos/security/wrappers: remove all the assertions about readlink(/proc/self/exe)
Given that we are no longer inspecting the target of the /proc/self/exe
symlink, stop asserting that it has any properties. Remove the plumbing
for wrappersDir, which is no longer used.

Asserting that the binary is located in the specific place is no longer
necessary, because we don't rely on that location being writable only by
privileged entities (we used to rely on that when assuming that
readlink(/proc/self/exe) will continue to point at us and when assuming
that the `.real` file can be trusted).

Assertions about lack of write bits on the file were
IMO meaningless since inception: ignoring the Linux's refusal to honor
S[UG]ID bits on files-writeable-by-others, if someone could have
modified the wrapper in a way that preserved the capability or S?ID
bits, they could just remove this check.

Assertions about effective UID were IMO just harmful: if we were
executed without elevation, the caller would expect the result that
would cause in a wrapperless distro: the targets gets executed without
elevation. Due to lack of elevation, that cannot be used to abuse
privileges that the elevation would give.

This change partially fixes #98863 for S[UG]ID wrappers. The issue for
capability wrappers remains.
2023-08-16 11:33:22 +02:00
..
config Revert "nixos/malloc: add back maybe unnecessary line" 2023-08-10 03:02:39 +02:00
hardware Merge pull request #244060 from Gerg-L/nvidiaDynamicBoost 2023-08-10 17:02:26 +02:00
i18n/input-method nixos/fcitx5: fix evaluation 2023-08-15 08:15:41 +08:00
image nixos/image: add image.repart.package option 2023-08-04 13:49:18 +02:00
installer Merge pull request #247475 from qowoz/nix217 2023-08-13 13:27:20 -04:00
misc Merge pull request #241462 from SuperSandro2000/remove-ddclient 2023-07-08 14:33:00 +02:00
profiles nixos/installation-device: allow nix-copy for root/nixos user 2023-08-07 16:48:49 +02:00
programs Merge pull request #248131 from Ma27/captive-browser-setcap 2023-08-12 14:52:38 +02:00
security nixos/security/wrappers: remove all the assertions about readlink(/proc/self/exe) 2023-08-16 11:33:22 +02:00
services Merge pull request #246181 from jvanbruegge/haproxy-package 2023-08-15 19:46:13 +02:00
system Merge pull request #220263 from samueldr/feature/misc-grub-fixes 2023-08-12 20:32:51 -04:00
tasks zfs: 'want', don't 'require', systemd-udev-settle 2023-07-28 16:57:12 +10:00
testing
virtualisation Merge pull request #232250 from YBeaugnon/libvirt-hooks 2023-08-09 15:07:52 +02:00
module-list.nix Merge pull request #246029 from ehmry/eris-go 2023-08-08 06:18:03 +02:00
rename.nix nixos/dhcp(46): remove 2023-07-28 16:35:40 +02:00