The current advice of "keeping the override interface" is actively bad, because it hides certain expectations of a package function in an undiscoverable place. Ideally, all information about a package is in one, single place instead. Version-specific argument names, if required, also have the *benefit* of creating errors with downstream overrides, much like merge conflicts do. Instead of possibly silently breaking certain behavior, they make a change in expectations clear - which might feel annoying when upgrading, but is ultimately much less problematic down the road.
7.4 KiB
Name-based package directories
The structure of this directory maps almost directly to top-level package attributes. Add new top-level packages to Nixpkgs using this mechanism whenever possible.
Packages found in the name-based structure are automatically included, without needing to be added to all-packages.nix. However if the implicit attribute defaults need to be changed for a package, this must still be declared in all-packages.nix.
Example
The top-level package pkgs.some-package may be declared by setting up this file structure:
pkgs
└── by-name
├── so
┊ ├── some-package
┊ └── package.nix
Where some-package is the attribute name corresponding to the package, and so is the lowercase 2-letter prefix of the attribute name.
The package.nix may look like this:
# A function taking an attribute set as an argument
{
# Get access to top-level attributes for use as dependencies
lib,
stdenv,
libbar,
# Make this derivation configurable using `.override { enableBar = true }`
enableBar ? false,
}:
# The return value must be a derivation
stdenv.mkDerivation {
# ...
buildInputs = lib.optional enableBar libbar;
}
You can also split up the package definition into more files in the same directory if necessary.
Once defined, the package can be built from the Nixpkgs root directory using:
nix-build -A some-package
See the general package conventions for more information on package definitions.
Changing implicit attribute defaults
The above expression is called using these arguments by default:
{
lib = pkgs.lib;
stdenv = pkgs.stdenv;
libbar = pkgs.libbar;
}
But the package might need pkgs.libbar_2 instead.
While the libbar argument could explicitly be overridden in all-packages.nix with libbar_2, this would hide important information about this package from its interface.
The fact that the package requires a certain version of libbar to work should not be hidden in a separate place.
It is preferable to use libbar_2 as a argument name instead.
This approach also has the benefit that, if the expectation of the package changes to require a different version of libbar, a downstream user with an override of this argument will receive an error.
This is comparable to a merge conflict in git: It's much better to be forced to explicitly address the conflict instead of silently keeping the override - which might lead to a different problem that is likely much harder to debug.
Manual migration guidelines
Most packages are still defined in all-packages.nix and the category hierarchy.
Since it would take a lot of contributor and reviewer time to migrate all packages manually,
an automated migration is planned,
though it is expected to still take some time to get done.
If you're interested in helping out with this effort,
please see this ticket.
Since only PRs to packages in pkgs/by-name can be automatically merged,
if package maintainers would like to use this feature, they are welcome to migrate their packages to pkgs/by-name.
To lessen PR traffic, they're encouraged to also perform some more general maintenance on the package in the same PR,
though this is not required and must not be expected.
Note that callPackage definitions in all-packages.nix with custom arguments should not be removed.
That is a backwards-incompatible change because it changes the .override interface.
Such packages may still be moved to pkgs/by-name however, in order to avoid the slightly superficial choice of directory / category in which the default.nix file was placed, but please keep the definition in all-packages.nix using callPackage.
See also changing implicit attribute defaults.
Definitions like the following however, can be transitioned:
# all-packages.nix
{
fooWithBaz = foo.override { bar = baz; };
}
# turned into pkgs/by-name/fo/fooWithBaz/package.nix with:
{ foo, baz }:
foo.override { bar = baz; }
Limitations
There are some limitations as to which packages can be defined using this structure:
-
Only packages defined using
pkgs.callPackage. This excludes packages defined usingpkgs.python3Packages.callPackage ....Instead:
- Either change the package definition to work with
pkgs.callPackage. - Or use the category hierarchy.
- Either change the package definition to work with
-
Only top-level packages. This excludes packages for other package sets like
pkgs.pythonPackages.*.Refer to the definition and documentation of the respective package set to figure out how such packages can be declared.
Validation
CI performs certain checks on the pkgs/by-name structure.
This is done using the nixpkgs-vet tool.
You can locally emulate the CI check using
$ ./ci/nixpkgs-vet.sh master
Recommendation for new packages with multiple versions
These checks of the pkgs/by-name structure can cause problems in combination:
- New top-level packages using
callPackagemust be defined viapkgs/by-name. - Packages in
pkgs/by-namecannot refer to files outside their own directory.
This means that outside pkgs/by-name, multiple already-present top-level packages can refer to some common file.
If you open a PR to another instance of such a package, CI will fail check 1,
but if you try to move the package to pkgs/by-name, it will fail check 2.
This is often the case for packages with multiple versions, such as
{
foo_1 = callPackage ../tools/foo/1.nix { };
foo_2 = callPackage ../tools/foo/2.nix { };
}
The best way to resolve this is to not use callPackage directly, such that check 1 doesn't trigger.
This can be done by using inherit on a local package set:
{
inherit
({
foo_1 = callPackage ../tools/foo/1.nix { };
foo_2 = callPackage ../tools/foo/2.nix { };
})
foo_1
foo_2
;
}
While this may seem pointless, this can in fact help with future package set refactorings, because it establishes a clear connection between related attributes.
Further possible refactorings
This is not required, but the above solution also allows refactoring the definitions into a separate file:
{ inherit (import ../tools/foo pkgs) foo_1 foo_2; }
# pkgs/tools/foo/default.nix
pkgs: {
foo_1 = callPackage ./1.nix { };
foo_2 = callPackage ./2.nix { };
}
Alternatively using callPackages
if callPackage isn't used underneath and you want the same .override arguments for all attributes:
{ inherit (callPackages ../tools/foo { }) foo_1 foo_2; }
# pkgs/tools/foo/default.nix
{ stdenv }:
{
foo_1 = stdenv.mkDerivation {
# ...
};
foo_2 = stdenv.mkDerivation {
# ...
};
}
Exposing the package set
This is not required, but the above solution also allows exposing the package set as an attribute:
{
foo-versions = import ../tools/foo pkgs;
# Or using callPackages
# foo-versions = callPackages ../tools/foo { };
inherit (foo-versions) foo_1 foo_2;
}